fix(rocksdb): fix compiler flag of rocksdb wrap #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speedup by Enable ROCKSDB_SCHED_GETCPU_PRESENT on Linux saving +20% CPU time
popcnt1
requested review from
jolestar,
wow-sven,
baichuan3 and
steelgeek091
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jolestar
approved these changes
Aug 1, 2024
Replaced the 'branch' reference with a fixed 'rev' tag for better control over dependencies. This ensures consistency in builds by pointing to a specific commit in the rust-rocksdb repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
speedup by Enable ROCKSDB_SCHED_GETCPU_PRESENT on Linux by replacing rocksdb rust wrap with these changes.
Will pull request to upstream later
saving 20-40% CPU time