fix: Display vector byte if movestring can't format to utf8 #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
baichuan3
reviewed
Aug 9, 2024
| Ok(s) => { | ||
| write!(f, "{}", s) | ||
| } | ||
| Err(_) => { |
There was a problem hiding this comment.
MoveString is new with utf8 check in the contract, and the Rust implementation should also check utf8
There was a problem hiding this comment.
If MoveString is a transaction argument or directly deserialized via bcs::from_bcs, we can not check the utf8.
baichuan3
approved these changes
Aug 9, 2024
|
I merge this PR first, but we need to add a test case. |
|
I have a simple test in local, but more test is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR