-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Indexer] Support query event by event type and sender #2405
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jojoo-eth @wow-sven @mx819812523, putting the filter_out
argument in the Option will break the SDK and PRC call.
We can unify them, but we need to support camelCase and snake_case both to avoid breaking RPC. |
Summary
filter_out
from ObjectStateFilterView::ObjectTypeWithOwner to QueryOptions, eliminate the restriction of forcing filter_out to be passed in ObjectStateFilterView::ObjectTypeWithOwnerTODO:
QueryOptions uses camelCase for serialization, and some parameters use snake_case for parameter passing. Should we unify them?
rooch_queryEvents
RPC to support combined sender and event_type filtering #2404