[gh-2471] add tx build command. #2472
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
feliciss
requested review from
wow-sven,
baichuan3 and
pause125
as code owners
| pub type_args: Vec<TypeTag>, | ||
|
|
||
| #[clap(long)] | ||
| pub args: Vec<Vec<u8>>, |
There was a problem hiding this comment.
Use FunctionArg to support args parse like rooch move run
| pub function_name: String, | ||
|
|
||
| #[clap(long)] | ||
| pub type_args: Vec<TypeTag>, |
There was a problem hiding this comment.
Use ParsedStructType like rooch move run
| pub module_address: AccountAddress, | ||
|
|
||
| #[clap(long, required = true)] | ||
| pub module_name: String, | ||
|
|
||
| #[clap(long, required = true)] | ||
| pub function_name: String, |
There was a problem hiding this comment.
The three option can merge to one ParsedFunctionId like rooch move run
| if self.output { | ||
| let tx_data_hex = hex::encode(tx_data.encode()); | ||
| if self.json { | ||
| Ok(Some(tx_data_hex)) | ||
| } else { | ||
| println!( | ||
| "Build transaction succeeded with the transaction hex [{}]", | ||
| tx_data_hex | ||
| ); | ||
|
|
||
| Ok(None) | ||
| } | ||
| } else if let Some(file_destination) = self.file_destination { | ||
| let mut file = File::create(file_destination)?; | ||
| file.write_all(&tx_data.encode())?; | ||
| println!("Write encoded tx data succeeded in the destination"); | ||
|
|
||
| Ok(None) | ||
| } else { | ||
| return Err(RoochError::CommandArgumentError( | ||
| "Argument --file-destination is not provided".to_owned(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
Remove the output option if we provide file_destination.
if file_destination is None, print the hex, otherwise write the tx to the file.
There was a problem hiding this comment.
Remove the output option if we provide
file_destination.if file_destination is None, print the hex, otherwise write the tx to the file.
I'll only resolve issues of the if else clause cause the write function is only functioning on vectors not hex strings.
Summary
Add
buildsubcommand forrooch txandrooch transaction.Example output (if writing to a file):
Example output (if outputting a hex):
rooch transaction build --function rooch_framework::empty::empty --json --output "0ea3bb55c14aec8e074cd48c6a850526aa46965e176df53fadb433adeeeb56570000000000000000040000000000000000e1f5050000000001000000000000000000000000000000000000000000000000000000000000000305656d70747905656d7074790000"rooch tx buildgenerate a RoochTransactionData via argument, and output tx hex or write to a file. #2471