Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smt] Rename hashtag to SMTNode and replace the HashValue with SMTNodeHash #2536

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

jolestar
Copy link
Contributor

Summary

  1. Rename the hashtag from rooch-smt to SMTNode because smt may be used in a different project than rooch.
  2. Replace the HashValue with SMTNodeHash.
  3. Improve the Merkle hash calculation.

Part of #2402

Do a simple benchmark:

  1. Before smt: Switch to SHA-256 hashing #2401
Screenshot 2024-08-29 at 14 14 59
  1. After smt: Switch to SHA-256 hashing #2401
Screenshot 2024-08-29 at 14 19 21
  1. this PR
Screenshot 2024-08-29 at 14 23 18

The db performance is regressed; maybe it is caused by disk usage.

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 8:24am
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 8:24am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2024 8:24am

Copy link

github-actions bot commented Aug 29, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants