Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[genesis] Genesis multisign config and release framework v8, testnet and mainnet genesis #2573

Merged
merged 8 commits into from
Sep 5, 2024
Merged

[genesis] Genesis multisign config and release framework v8, testnet and mainnet genesis #2573

merged 8 commits into from
Sep 5, 2024

Conversation

jolestar
Copy link
Contributor

@jolestar jolestar commented Sep 4, 2024 •
edited
Loading

Summary

  1. Refactor MoveOS, migrate the apply_transaction_output to MoveOSStore, and merge to handle_tx_output.
  2. Refactor Genesis and keep the RawTransactionOutput in the genesis file.
  3. Fix the TapRoot tree node encode bug.
  4. Update genesis multisign config

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 9:27am
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 9:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 9:27am

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

baichuan3
baichuan3 reviewed Sep 4, 2024
View reviewed changes
crates/rooch-types/src/genesis_config.rs
)
.unwrap(),
threshold: 2,
threshold: 5,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 is too many, I recommend 3

@jolestar jolestar marked this pull request as ready for review September 4, 2024 12:33
@jolestar jolestar changed the title Genesis multisign config [genesis] Genesis multisign config and release framework v8, testnet and mainnet genesis Sep 5, 2024
@jolestar jolestar merged commit 56461ac into main Sep 5, 2024
8 of 9 checks passed
@jolestar jolestar deleted the genesis_multisign_config branch September 5, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popcnt1 popcnt1 popcnt1 left review comments

@steelgeek091 steelgeek091 steelgeek091 approved these changes

@baichuan3 baichuan3 baichuan3 approved these changes

@wow-sven wow-sven Awaiting requested review from wow-sven wow-sven is a code owner

@Mine77 Mine77 Awaiting requested review from Mine77

@mx819812523 mx819812523 Awaiting requested review from mx819812523

@pause125 pause125 Awaiting requested review from pause125 pause125 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolestar @baichuan3 @steelgeek091 @popcnt1