Gas Profiling Implementation #2616
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
steelgeek091
force-pushed
the
gas_profiling
branch
from
c87032e
to
2141623
Compare
steelgeek091
force-pushed
the
gas_profiling
branch
from
c79e00b
to
1a93d61
Compare
steelgeek091
force-pushed
the
gas_profiling
branch
from
72b6901
to
3dbc581
Compare
enable the gas event recording finish the gas profiling convert linear gas event list to stacked implement flamegraph for execution cargo clippy render html template add the content of the execution trace Put the gas profiling in moveos repo implement ClassifiedGasMeter and SwitchableGasMeter for GasProfiler cargo fmt add function execute_tx_locally add an command line argument for getStates command integrate gas profiler into the tx execution flow
steelgeek091
force-pushed
the
gas_profiling
branch
from
900a100
to
1dd7886
Compare
| @@ -146,7 +146,12 @@ impl Handler<StatesMessage> for ReaderExecutorActor { | |||
| msg: StatesMessage, | |||
| _ctx: &mut ActorContext, | |||
| ) -> Result<Vec<Option<ObjectState>>, anyhow::Error> { | |||
| let resolver = RootObjectResolver::new(self.root.clone(), &self.moveos_store); | |||
| let resolver = if let Some(state_root) = msg.state_root { | |||
| let root_object_meta = ObjectMeta::root_metadata(state_root, 55); | |||
There was a problem hiding this comment.
How should we handle the size parameter?
Should it be passed from the client or retrieved from Node?
There was a problem hiding this comment.
Another way to implement it is to modify the state_resolver StateReader trait to support get_states and list_states by state root, so there is no need to construct a new RootObject
There was a problem hiding this comment.
In the read-only case, the VM do not use the size param, it can be zero.
There was a problem hiding this comment.
It is workable to implement this by directly setting the RootObject size to 0, but is there any ambiguity in constructing the RootObject for any state root query, such as the state root of a child object tree?
There was a problem hiding this comment.
The size is used by the ObjectRuntime; if the contract removes an element, the size will reduce. We do not record all Global root objects. This is a workaround solution; we will need to refactor in the future.
There was a problem hiding this comment.
Do not need to record all Global root objects , just modify the state_resolver StateReader trait to support get_states and list_states by state root , and it can elegantly solve the querying arbitrary state root scenarios.
It can be put in the subsequent refactor.
There was a problem hiding this comment.
There is already a StatelessResolver, which supports get_states by root; StateResolver is for the pin on a state_root and get states many times.
steelgeek091
requested review from
pause125,
jolestar,
wow-sven,
baichuan3 and
popcnt1
as code owners
| @@ -146,7 +146,12 @@ impl Handler<StatesMessage> for ReaderExecutorActor { | |||
| msg: StatesMessage, | |||
| _ctx: &mut ActorContext, | |||
| ) -> Result<Vec<Option<ObjectState>>, anyhow::Error> { | |||
| let resolver = RootObjectResolver::new(self.root.clone(), &self.moveos_store); | |||
| let resolver = if let Some(state_root) = msg.state_root { | |||
| let root_object_meta = ObjectMeta::root_metadata(state_root, 55); | |||
There was a problem hiding this comment.
In the read-only case, the VM do not use the size param, it can be zero.
No description provided.