fix 전적 검색 KR_ 안붙여줘서 발생할 수 있는 버그 수정 #25

rookedsysc · Mar 17, 2024 · c3f848a · c3f848a
1 parent f707442
commit c3f848a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/com/gamemoonchul/application/BoardService.java b/src/main/java/com/gamemoonchul/application/BoardService.java
@@ -18,12 +18,12 @@ public class BoardService {
     private final LolSearchAdapter lolSearchAdapter;
 
     public MatchGameResponse searchMatch(String gameId) {
-        Optional<MatchGame> optionalEntity = matchGameService.findById(gameId);
+        Optional<MatchGame> savedEntity = matchGameService.findByGameId(gameId);
         MatchGame matchGame;
 
 
-        if (optionalEntity.isPresent()) {
-            matchGame = optionalEntity.get();
+        if (savedEntity != null && savedEntity.isPresent()) {
+            matchGame = savedEntity.get();
         } else {
             MatchRecord vo = lolSearchAdapter.searchMatch(gameId);
             matchGame = matchGameService.save(vo);

diff --git a/src/main/java/com/gamemoonchul/application/MatchGameService.java b/src/main/java/com/gamemoonchul/application/MatchGameService.java
@@ -17,7 +17,7 @@ public class MatchGameService {
     private final MatchGameRepository matchGameRepository;
     private final MatchGameConverter matchConverter;
 
-    public Optional<MatchGame> findById(String gameId) {
+    public Optional<MatchGame> findByGameId(String gameId) {
         return matchGameRepository.findByGameId(gameId);
     }
 

diff --git a/src/main/java/com/gamemoonchul/infrastructure/web/BoardApiController.java b/src/main/java/com/gamemoonchul/infrastructure/web/BoardApiController.java
@@ -17,7 +17,7 @@ public class BoardApiController {
 
     @GetMapping("/search-match/{gameId}")
     public MatchGameResponse searchMatch(@PathVariable String gameId) {
-        return boardService.searchMatch(gameId);
+        return boardService.searchMatch("KR_" + gameId);
     }
 
     @PostMapping("/video-upload")

diff --git a/src/test/java/com/gamemoonchul/application/MatchGameServiceTest.java b/src/test/java/com/gamemoonchul/application/MatchGameServiceTest.java
@@ -47,7 +47,7 @@ void setMatchGameService() {
         List<MatchUser> matchUsers = matchUserService.saveAll(dummyVO.info().participants(), matchGame);
 
         // when
-        Optional<MatchGame> optionalMatchGame = matchGameService.findById(matchGame.getGameId());
+        Optional<MatchGame> optionalMatchGame = matchGameService.findByGameId(matchGame.getGameId());
         MatchGame result = optionalMatchGame.get();
 
         // then