-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Winrate Graph now shows the centipawn value as a hover annotation when you move the mouse #235
base: master
Are you sure you want to change the base?
Conversation
Thanks. Nibbler isn't really maintained right now, the codebase is too complicated and really should be rewritten - so I don't promise to get to this any time very soon. |
Understood. FWIW I've been running this locally for my own use, and it works well for me. |
Fixed a couple rendering bugs in 27edd29 should be good to go now. |
Converting to draft until #244 is resolved, since the hover depends on the graph data structures. |
6c69ab3
to
411dccf
Compare
411dccf
to
4c06173
Compare
…s easier to pinpoint the exact move you want to click on
…clicked "Tree > Delete node" from the menu
Updated to match #244 September 25, 2023:
|
96a3af5
to
f95224e
Compare
* Graph y-value matches centipawns graph * Hover shows centipawns rather than winpct
f95224e
to
cad8f4b
Compare
Component
Winrate Graph
Implemented in this PR
When hovering the mouse inside the winrate graph, show the move token & eval value of the move you are hovering over.
last_hover_node
as state to the Grapher in files/src/renderer/55_winrate_graph.jslast_hover_node
grapher.draw_everything
calldraw_hover_annotation
to show token + eval of the last hovered node.is_inside_graph_canvas
to check when the mouse leaves the graph canvas, at which point we clearlast_hover_node
so that the hover annotation is no longer drawn.Testing
When hovering a move that has an eval:
When hovering a move that doesn't have an eval: