Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw faint shaded areas around the eval line to indicate likeliness of a decisive result #248

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    d0e823b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09e91bb View commit details
    Browse the repository at this point in the history
  3. Render a faint gray area around the eval line based on the likelyness of

    a decisive result according to WDL
    
    * When eval is close to zero, this allows users to more easily identify
      which "drawn" positions are actually dead drawn vs.
      unclear/complex/sharp
    * When eval favors one side, this allows users to more easily identify
      which portions of the game contained more counterplay/complexity
      despite the advantage
    yuzisee committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    75c9c80 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. No functional change.

    Help to reduce merge conflicts w/ rooklift#237
    yuzisee committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    279e905 View commit details
    Browse the repository at this point in the history
  2. Minor bugfix

    yuzisee committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    13097a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Configuration menu
    Copy the full SHA
    aa07184 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2516d3 View commit details
    Browse the repository at this point in the history
  3. Review response to

    rooklift#248 (comment)
    
    Draw as a "WDL graph" instead
    yuzisee committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    51c4687 View commit details
    Browse the repository at this point in the history
  4. Bugfix (corner case)

    * Handle null values correctly
    yuzisee committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    9dad848 View commit details
    Browse the repository at this point in the history
  5. Review response to rooklift#248 (comment)

    Directly use the `WDL_mu` stddev formula `2 / (ln(1/W-1) + ln(1/L-1))` to calculate the interval around the eval line.
    yuzisee committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    107710b View commit details
    Browse the repository at this point in the history
  6. Review response to rooklift#248 (comment)

    "I just realized that optically it suggests the opposite of what your initial plots did (i.e. the draw area going to 100% in case of a draw), and if you stick to the idea of the shaded areas representing uncertainty about the eval, I think the currently black part should be shaded instead"
    yuzisee committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    696c576 View commit details
    Browse the repository at this point in the history
  7. Review response to rooklift#248 (comment)

    "There are probably some edge case issues with `W` or `L` being reported as 0 you need to deal with, e.g. by scaling WDL by 0.994 and adding 0.2% to each of W,D,L when calculating the line."
    yuzisee committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    bfe752a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Draw the actual (raw) WDL instead

    (and leaving it to the user to use adequate WDL sharpness through the contempt settings)
    yuzisee committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    592478a View commit details
    Browse the repository at this point in the history