Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized country names from Java's built-in Locale object. #14

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

tladesignz
Copy link

Additional contains a small cleanup (e.g. fixed some lint warnings) and the latest SDK target.
Fixes issue #11

@Ricardo1980
Copy link

Why "Pushed target SDK from 17 to 21."? Thanks.

@tladesignz
Copy link
Author

Because, when you start a new project (or even update an older one, if possible, which is mostly always since Android 4.0), you should always target the newest API version. Otherwise, compatibility behaviour would be in place on newer devices, which can, in some instances, slow things down and even degrade the UI to an older version.

Also, your project uses the API 4 compatibility library, which many consuming projects also use, and which gets updated often. But the version of that library in your project and in the consuming project have to be the same.

And since I definitely don't target an old API version on a new project using old libraries, yours had to get updated.

If you, for some reason, really don't like that, you could also cherry-pick the commits you like, which would be commit c0da63d and 1ab1152, most probably.

@Ricardo1980
Copy link

Never mind, I was just curious. BTW I'm not the owner of the project.

@tladesignz
Copy link
Author

Ah. Didn't get that. You were the poster of issue #11. Thanks for the clue. :-) Anyway, feel free to pull or fork from me, if roomorama doesn't want to merge.

@thomasdao
Copy link
Contributor

@tladesignz thanks for the PR, sorry recently I've been quite busy at work. Would you mind converting the project into Android Studio format? After that I would put it to Maven so it's easier to use with Gradle. Thanks

@tladesignz
Copy link
Author

Hi! Sorry, cannot. I'm still on Eclipse and will be staying there for the current project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants