Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back the tabs layout #238

Closed
AlbertoPdRF opened this issue Jun 28, 2022 · 4 comments
Closed

Bring back the tabs layout #238

AlbertoPdRF opened this issue Jun 28, 2022 · 4 comments
Assignees
@linev
Labels
enhancement

Comments

@AlbertoPdRF
Copy link

Is it possible to re-implement the tabs layout? For reference, see point 6 of https://github.com/root-project/jsroot/releases/tag/7.0.0
@linev linev self-assigned this Jun 28, 2022
@linev
Copy link
Member

linev commented Jun 28, 2022

Yes, it can be done.
I exclude them while complete jQuery was removed.

AlbertoPdRF added a commit to AlbertoPdRF/root-file-viewer that referenced this issue Jun 28, 2022
@AlbertoPdRF
Upgrade JSROOT to v7.1.0 🆙
740e135 
Note that this change required getting rid of the `tabs` layout, but it will likely come back at some point, see root-project/jsroot#238
@olifre olifre mentioned this issue Jun 28, 2022
Closed
linev added a commit that referenced this issue Jul 6, 2022
@linev
Provide build, log and date for new tabs layout #238
42c4d78
@linev
Copy link
Member

linev commented Jul 6, 2022

Tabs layout is now implemented in the master branch.

@linev
Copy link
Member

linev commented Aug 11, 2022

Now available in 7.2.0 release

@linev linev closed this as completed Aug 11, 2022
@AlbertoPdRF
Copy link
Author

Thank you @linev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linev linev

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linev @AlbertoPdRF