Add basic TypeScript types

[9inpachi]

Sorry, with #245 earlier today, in a hurray I ended up placing the browser field above the other module related fields. This is just to move that field lower and make the readability easier.

[linev]

I just move today browser field to the end of package.json - see

d2f95f7

[9inpachi]

Ahan, cool. I didn't notice that commit. Thanks.

Then, I will keep this PR open to push some very basic types setup to make imports by name work in TypeScript. Because import { build } from 'jsroot/geom'; works but throws an error in TypeScript unless we use // @ts-ignore.

[9inpachi]

There are following ways of fixing the types error.

1. Using node16 as the moduleResolution option in TypeScript. This is able to pick the exported modules from package.json's exports field but still shows a warning that the types are not there.
2. Declaring TypeScript modules using "magically available interfaces"/"global types" like I did in this PR. This does not add any actual types but just declares the modules to direct TypeScript that it's a known module without any types.
3. The most thorough way is to generate declaration files for the JavaScript code. This is done with JSDoc that's used to document types in JavaScript code. I gave it a try so it's in the commit history (can be reverted with 09f2d6c). It works but there seem to be some wrong types declared through JSDoc like object instead of Object3D for a three.js object which causes problems when we actually use the API interface.

I implemented the second option since it's the simplest without any side effects and without any need to change anything on the consumer side.

[9inpachi]

HSF/phoenix#497 needs this to pass the pipeline and complete the update.

[9inpachi]

@linev could you please take a look at this?

[linev]

Does it work for you?

If yes - I will be able to check it begin of next week.

[9inpachi]

Yes, it does work. I have added a temporary tag (7.2.0-types) on my fork and I am using that in Phoenix for now to not block us. So there is no urgency to merge this.

…

On Wed, Sep 21, 2022, 10:41 PM Sergey Linev ***@***.***> wrote: Does it work for you? If yes - I will be able to check it begin of next week. — Reply to this email directly, view it on GitHub <#246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZVY6MEYDE5Y3TSKAO6CMDV7NCDRANCNFSM6AAAAAAQCQV2CU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[9inpachi]

@linev it seems that the types are not added to the latest released version. Do you plan to make it a part of the major version release?

[linev]

It will be in 7.3.0 version, which I plan to release shortly before next ROOT 6.28 release.
Up to now there is no concrete plans for it.
If necessary, I can backport changes to 7.2 branch and produce 7.2.2 tag.

[9inpachi]

I think it's fine to release it with 7.3.0. I just wanted to confirm. Thanks. Best, Fawad

…

On Thu, Dec 1, 2022 at 8:25 AM Sergey Linev ***@***.***> wrote: It will be in 7.3.0 version, which I plan to release shortly before next ROOT 6.28 release. Up to now there is no concrete plans for it. If necessary, I can backport changes to 7.2 branch and produce 7.2.2 tag. — Reply to this email directly, view it on GitHub <#246 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZVY6I2DMW3M3DL27RXAD3WLBHFFANCNFSM6AAAAAAQCQV2CU> . You are receiving this because you authored the thread.Message ID: ***@***.***>