[RF] Add flag to globally enable or disable all RooBinWidthFunctions #10213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgard
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Can one of the admins verify this patch? |
Contributor
|
@phsft-bot build |
|
Starting build on |
guitargeek
reviewed
Mar 29, 2022
guitargeek
reviewed
Mar 29, 2022
guitargeek
requested changes
Mar 29, 2022
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Hi @cburgard! Sorry for the delay, yes this can be merged almost as is, I just have small requests about the names and doxygen.
Contributor
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
23 tasks
Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
Implemented suggestions
guitargeek
changed the title
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
guitargeek
force-pushed
the
roobinwidthfunction-flag
branch
from
ed0eb65 to
d989462
Compare
Contributor
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on ROOT-ubuntu2004/soversion. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on mac11/cxx17. Failing tests: |
guitargeek
approved these changes
Mar 30, 2022
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvements! I'll merge now, the unit test failures are unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
With the (very useful) introduction of the RooBinWidthFunction, the bin width correction moved from the "coefficient" branch of the RooRealSumPdf to the "function" branch of the RooRealSumPdf in HistFactory.
This can cause some distress for users who meddle with histfactory models by hand, because bin correction can now appear at places that are different from what they were originally.
This PR adds a flag to globally disable all bin width corrections of RooBinWidthFunction, allowing the user to switch an entire model from density-mode to eventcount-mode.
Changes or fixes:
Added flag to globally enable or disable all bin width functions.
Checklist:
This PR fixes #