Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Added missing snapshot creation #10293

Merged
merged 2 commits into from
Apr 11, 2022
Merged

[RF] Added missing snapshot creation #10293

merged 2 commits into from
Apr 11, 2022

Conversation

cburgard
Copy link
Contributor

@cburgard cburgard commented Apr 1, 2022

This Pull request:

Fixes a bug where snapshots were not imported from JSON.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@cburgard cburgard changed the title added missing snapshot creation [RF] added missing snapshot creation Apr 1, 2022
@cburgard
Copy link
Contributor Author

cburgard commented Apr 1, 2022

@guitargeek please take a look at this small bugfix. does this qualify to be backported?

1 similar comment
@cburgard
Copy link
Contributor Author

cburgard commented Apr 1, 2022

@guitargeek please take a look at this small bugfix. does this qualify to be backported?

Axel-Naumann
Axel-Naumann previously requested changes Apr 4, 2022
View reviewed changes
roofit/hs3/src/RooJSONFactoryWSTool.cxx Outdated Show resolved Hide resolved
@guitargeek
Copy link
Contributor

Hi, thanks for the PR!

Yes, that's qualifying also for a backport, but please run clang-format with the root style to get rid of the tabs before we can merge.

@cburgard
Copy link
Contributor Author

cburgard commented Apr 4, 2022

done, I hope

@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@cburgard
Copy link
Contributor Author

cburgard commented Apr 8, 2022

Is there still anything left to be done? I see the check failing, but I can't see why.

@guitargeek guitargeek mentioned this pull request Apr 8, 2022
Closed
23 tasks
@guitargeek
Copy link
Contributor

The failing checks are unrelated, I'll merge now. Thanks for the PR 👍

@guitargeek guitargeek dismissed Axel-Naumann’s stale review April 11, 2022 11:07

Review comments addressed

@guitargeek guitargeek merged commit 66216b1 into root-project:master Apr 11, 2022
@guitargeek guitargeek changed the title [RF] added missing snapshot creation [RF] Added missing snapshot creation Apr 11, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-11T11:13:17.113Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

@guitargeek guitargeek mentioned this pull request Apr 11, 2022
Merged
@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2022-04-11T11:51:42.108Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Target\NVPTX\LLVMNVPTXCodeGen.vcxproj]
  • [2022-04-11T11:51:42.108Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Target\NVPTX\LLVMNVPTXCodeGen.vcxproj]
  • [2022-04-11T11:51:42.108Z] c1xx : fatal error C1356: unable to find mspdbcore.dll [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Target\NVPTX\LLVMNVPTXCodeGen.vcxproj]
  • [2022-04-11T11:51:42.108Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\include\clang/Basic/TargetBuiltins.h(174,8): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\CodeGen\CGException.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\CodeGen\obj.clangCodeGen.vcxproj]
  • [2022-04-11T11:51:42.108Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1817,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\AST\ASTDiagnostic.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2022-04-11T11:51:42.585Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/Support/Chrono.h(38,1): fatal error C1060: compiler is out of heap space [C:\build\workspace\root-pullrequests-build\build\core\metacling\src\MetaCling.vcxproj]
  • [2022-04-11T11:51:42.585Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1704,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\CodeGen\MachineLoopInfo.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\CodeGen\LLVMCodeGen.vcxproj]
  • [2022-04-11T11:51:42.585Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xutility(1309,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Scalar\Sink.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Scalar\LLVMScalarOpts.vcxproj]
  • [2022-04-11T11:51:42.585Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\tuple(177,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\CodeGen\MIRPrintingPass.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\CodeGen\LLVMCodeGen.vcxproj]
  • [2022-04-11T11:51:42.585Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\include\clang/Lex/Preprocessor.h(310,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Parse\ParseStmtAsm.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Parse\obj.clangParse.vcxproj]

And 126 more

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-04-11T13:12:24.060Z] FAILED: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download /Volumes/HD2/build/workspace/root-pullrequests-build/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-download
  • [2022-04-11T13:12:24.060Z] CMake Error at XROOTD-stamp/XROOTD-download-Release.cmake:49 (message):
  • [2022-04-11T13:12:24.060Z] FAILED: builtins/davix/DAVIX-prefix/src/DAVIX-stamp/DAVIX-download /Volumes/HD2/build/workspace/root-pullrequests-build/build/builtins/davix/DAVIX-prefix/src/DAVIX-stamp/DAVIX-download
  • [2022-04-11T13:12:24.060Z] CMake Error at DAVIX-stamp/DAVIX-download-Release.cmake:49 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guitargeek guitargeek guitargeek approved these changes

@Axel-Naumann Axel-Naumann Axel-Naumann left review comments

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees

@guitargeek guitargeek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cburgard @phsft-bot @guitargeek @Axel-Naumann