Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Implement likelihood offsetting in new RooFit BatchMode #10802

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

guitargeek
Copy link
Contributor

This is necessary to make the more complicated fits converge, like the
ATLAS Higgs combination fits.

Verified

This commit was signed with the committer’s verified signature.
Freyskeyd Simon Paitrault
This is necessary to make the more complicated fits converge, like the
ATLAS Higgs combination fits.
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Is the offset in the batch mode computed as in the serial one, or does it include the extended term ?

@guitargeek
Copy link
Contributor Author

For better comparison, the offset is computed as the same point as in serial mode: after adding the extended term, but without considering the constraints.

@lmoneta
Copy link
Member

lmoneta commented Jun 22, 2022

Sounds good ! Thank you !

@guitargeek guitargeek merged commit 8e6ca16 into root-project:master Jun 22, 2022
@guitargeek guitargeek deleted the batchmode_offset_1 branch June 22, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants