[v626][RF] Backports of RooFit PRs to v6-26-00-patches: Part 24
#11748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This virtual funciton was only implemented as a dummy and didn't get overloaded in any for the classes deriving from RooPlot (there are none).
The iteration over the plotted `_items` should be in reverse order to consider the last-plotted curve for the residual histogram. Also, this commit imporves the support for multi-range residuals by making sure that multiple curves with the same name are only considered if the curves are not overlapping. This commit is a fixup to commit b4bf80c.
In this forum post, the point was made that `RooWorkspace::getSnapshot()` should not print an error if a snapshot with the passed name is not found. https://root-forum.cern.ch/t/roofit-check-if-snapshot-exist-without-showing-objecthandling-error Just like in the other `RooWorkspace` access functions, like `arg()`, `pdf()`, or `function()`, users expect to use `getSnapshot()` also to query if a snapshot exists and check if the returned value is `nullptr`. So there should be no error printed in `getSnapshot()` itself. If it is actually an error for th caller that no snapshot has been found, an error or exception should be raised by the caller.
|
Starting build on |
This was referenced Nov 19, 2022
1 task
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
Build failed on mac12/noimt. Warnings:
And 64 more Failing tests: |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Failing tests: |
|
Build failed on ROOT-debian10-i386/soversion. Failing tests: |
|
Build failed on mac11/cxx14. Failing tests: |
|
Build failed on windows10/cxx14. Failing tests: |
guitargeek
force-pushed
the
v6-26-00-patches_roofit_backports_24
branch
from
8ffdc28 to
0752e45
Compare
|
Starting build on |
|
Build failed on mac12/noimt. Warnings:
And 64 more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the relevant bugfix RooFit PRs that were recently merged to master to v6-26-00-patches (in the right order, to not have the commit history diverge too much).
RooPlot::residHist()#11566RooWorkspace::getSnapshot()if no snapshot found #11584Only the first commit that is not code modernization
Related to #11534.