Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TCling] Fix suppression of enum forward declarations [v6.28] #13326

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jul 26, 2023

There can be multiple attributes in the forward declaration, see the added test in roottest/cling/dict/enum (reduced from a case reported by CMS in cms-sw/cmssw#42234), so we have to look for the last closing parentheses.

(cherry picked from commit 9d2f761, backport of #13319)

There can be multiple attributes in the forward declaration, see the
added test in roottest/cling/dict/enum (reduced from a case reported
by CMS in cms-sw/cmssw#42234), so we have
to look for the last closing parentheses.

(cherry picked from commit 9d2f761)
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Collaborator

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2023-07-26T10:30:47.752Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/machine/macos_common.h:55:13: warning: 'OSAtomicCompareAndSwap64Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_compare_exchange_strong() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.752Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/machine/macos_common.h:59:28: warning: 'OSAtomicAdd64' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_fetch_add_explicit(std::memory_order_relaxed) from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/machine/macos_common.h:100:13: warning: 'OSAtomicCompareAndSwap32Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_compare_exchange_strong() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/machine/macos_common.h:110:12: warning: 'OSAtomicAdd32Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_fetch_add() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/machine/macos_common.h:116:12: warning: 'OSAtomicAdd64Barrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_fetch_add() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/tbb_machine.h:339:31: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/tbb_machine.h:608:9: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/tbb_machine.h:612:9: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/tbb_machine.h:635:9: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
  • [2023-07-26T10:30:47.753Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/ginclude/tbb/tbb_machine.h:645:9: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]

And 113 more

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/soversion.
See console output.

@hahnjo hahnjo merged commit 6fc4f0f into root-project:v6-28-00-patches Jul 27, 2023
@hahnjo hahnjo deleted the cling-dict-enum-v628 branch July 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants