Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] Improve RPagePool #16859

Merged
merged 13 commits into from
Nov 15, 2024
Merged

[ntuple] Improve RPagePool #16859

merged 13 commits into from
Nov 15, 2024

Commits on Nov 14, 2024

  1. [ntuple] move RPagePool's refcounter to page info

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9eeeeb1 View commit details
    Browse the repository at this point in the history

  2. [ntuple] add RPagePool::RKey

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    85859df View commit details
    Browse the repository at this point in the history

  3. [ntuple] remove RPage::fColumnId

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    af5ccec View commit details
    Browse the repository at this point in the history

  4. [ntuple] remove RPage::MakePageZero() 

    Instead of mapping all synthezised zero pages to the same memory buffer,
use real allocated and zeroed out pages. That makes sure no special
logic is required when adding and removing pages to and from the page
pool.
    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6f1fa5c View commit details
    Browse the repository at this point in the history

  5. [ntuple] add RPagePool::fLookupByBuffer 

    Allows for O(1) page lookup when a page is returned to the page pool,
instead of the O(n) linear search.
    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8e4ad89 View commit details
    Browse the repository at this point in the history

  6. [ntuple] merge RPagePool::fPages and RPagePool::fPageInfos

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c2a46e0 View commit details
    Browse the repository at this point in the history

  7. [ntuple] add RPagePool::fLookupByKey 

    Use a hash map to filter the pages in the page pool by column ID and
on-disk type on access.
    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2db1cd5 View commit details
    Browse the repository at this point in the history

  8. [ntuple] minor code simplification 

    Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
    @jblomer @hahnjo
    jblomer and hahnjo committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    55fc1ca View commit details
    Browse the repository at this point in the history

  9. [ntuple] make RPagePool::REntry::fRefCounter 64bit

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    605e6db View commit details
    Browse the repository at this point in the history

  10. [ntuple] consolidate more logic in RPagePool::AddPage()

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6057f54 View commit details
    Browse the repository at this point in the history

  11. [ntuple] minor performance improvement in RPagePool::ReleasePage()

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a3a2322 View commit details
    Browse the repository at this point in the history

  12. [ntuple] add assert()s in RPage(Pool) logic

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1635fcd View commit details
    Browse the repository at this point in the history

  13. [ntuple] update limits test

    @jblomer
    jblomer committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    15b33c0 View commit details
    Browse the repository at this point in the history