Revert "[tutorials] Rename TMVA to Machine Learning category." #17200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f79b53c.
guitargeek
added
in:TMVA
pr:emergency🚨
guitargeek
requested review from
bellenot,
couet,
lmoneta,
dpiparo and
vepadulano
as code owners
guitargeek
removed
the
pr:emergency🚨
Test Results 17 files 17 suites 3d 20h 8m 9s ⏱️ For more details on these failures, see this check. Results for commit a77ef6d. |
|
Hi, let's go ahead with this PR and revert the renaming of the category to make it less confusing for the users of TMVA @lmoneta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f79b53c from #17098.
The same comments I made in #17193 should have been made there. Organizing the categories in doxygen doesn't necessitate moving the files - destroying the commit history in the process.
Such large-scale renames should have been approved also by the code owners 🙂
This PR is not to be merged immediately, let's first see the status of the CI with the revert and then discuss how to proceed together.