Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] set NEntries in RPagePersistentSink::InitFromDescriptor #17306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ntuple] set NEntries in RPagePersistentSink::InitFromDescriptor #17306

wants to merge 1 commit into from

Conversation

silverweed
Copy link
Contributor

Also add a bunch of reserve() where appropriate

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Dec 19, 2024
@silverweed silverweed requested a review from jblomer as a code owner December 19, 2024 10:47
jblomer
jblomer approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Test Results

    18 files      18 suites   4d 10h 15m 38s ⏱️
 2 682 tests  2 680 ✅ 0 💤 2 ❌
46 556 runs  46 553 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 1925f52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer jblomer approved these changes

@hahnjo hahnjo Awaiting requested review from hahnjo

@vepadulano vepadulano Awaiting requested review from vepadulano

@enirolf enirolf Awaiting requested review from enirolf

Assignees

@silverweed silverweed

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silverweed @jblomer