[ntuple] support rules with source class != dest class #18357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 16h 1m 6s ⏱️ Results for commit db746d4. |
silverweed
reviewed
Apr 11, 2025
| for (auto linkId : fieldDesc.GetLinkIds()) { | ||
| const auto &subFieldDesc = desc.GetFieldDescriptor(linkId); | ||
| regularSubfields.insert(subFieldDesc.GetFieldName()); | ||
| } | ||
|
|
||
| rules = FindRules(&fieldDesc); | ||
|
|
||
| // If the field's type name is not the on-disk name but we found a rule, we know it is valid to read | ||
| // on-disk data because we found the rule according to the on-disk (source) type name and version/checsksum. |
There was a problem hiding this comment.
Suggested change
| // on-disk data because we found the rule according to the on-disk (source) type name and version/checsksum. | |
| // on-disk data because we found the rule according to the on-disk (source) type name and version/checksum. |
|
Maybe related: https://its.cern.ch/jira/browse/ROOT-114 |
hahnjo
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
LGTM, see Giacomo's comment about a typo.
Note that, if I remember correctly, it is also possible to write entire class rename rules with only sourceClass and targetClass, but no source and target. I believe then all members are subject to automatic evolution, but should be checked. In a first implementation, we could require explicit copying of all members by the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including class rename rules.