-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ntuple] support rules with source class != dest class #18357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 18 files 18 suites 4d 7h 6m 17s ⏱️ Results for commit acade47. ♻️ This comment has been updated with latest results. |
|
Maybe related: https://its.cern.ch/jira/browse/ROOT-114 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see Giacomo's comment about a typo.
Note that, if I remember correctly, it is also possible to write entire class rename rules with only sourceClass and targetClass, but no source and target. I believe then all members are subject to automatic evolution, but should be checked. In a first implementation, we could require explicit copying of all members by the rule.
Co-authored-by: Silverweed <7806878+silverweed@users.noreply.github.com>
6bb4b77 to
acade47
Compare
That is accurate and nicked named 'renaming rule'
This would be sub-optimal as this would mean that for 'renamed' classes (using that type of rule), individual members/column would not be readable on their own; you would have to read the whole object 'all' the time. |
| bits |= 137; /* placeholder for randomizing the 8 LSBs */ \ | ||
| std::memcpy(&fLast8BitsZero, &bits, sizeof(fLast8BitsZero)); }" | ||
|
|
||
| #pragma link C++ options = version(3) class OldName < int> + ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#pragma link C++ options=version(3) class OldName<int>+;
is more typical white spacing.
Including class rename rules.