Skip to content

Conversation

@jblomer
Copy link
Contributor

@jblomer jblomer commented Apr 10, 2025

Including class rename rules.

@jblomer jblomer added this to the 6.36.00 milestone Apr 10, 2025
@jblomer jblomer self-assigned this Apr 10, 2025
@github-actions
Copy link

github-actions bot commented Apr 11, 2025

Test Results

    18 files      18 suites   4d 7h 6m 17s ⏱️
 2 738 tests  2 738 ✅ 0 💤 0 ❌
47 611 runs  47 611 ✅ 0 💤 0 ❌

Results for commit acade47.

♻️ This comment has been updated with latest results.

@ferdymercury
Copy link
Collaborator

Maybe related: https://its.cern.ch/jira/browse/ROOT-114

Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see Giacomo's comment about a typo.

Note that, if I remember correctly, it is also possible to write entire class rename rules with only sourceClass and targetClass, but no source and target. I believe then all members are subject to automatic evolution, but should be checked. In a first implementation, we could require explicit copying of all members by the rule.

jblomer and others added 2 commits April 14, 2025 14:17
Co-authored-by: Silverweed <7806878+silverweed@users.noreply.github.com>
@jblomer jblomer force-pushed the ntuple-rename-rules branch from 6bb4b77 to acade47 Compare April 14, 2025 12:25
@dpiparo dpiparo merged commit 0faf1f2 into root-project:master Apr 14, 2025
22 checks passed
@pcanal
Copy link
Member

pcanal commented Apr 14, 2025

Note that, if I remember correctly, it is also possible to write entire class rename rules with only sourceClass and targetClass, but no source and target.

That is accurate and nicked named 'renaming rule'

I believe then all members are subject to automatic evolution, but should be checked. In a first implementation, we could require explicit copying of all members by the rule.

This would be sub-optimal as this would mean that for 'renamed' classes (using that type of rule), individual members/column would not be readable on their own; you would have to read the whole object 'all' the time.

bits |= 137; /* placeholder for randomizing the 8 LSBs */ \
std::memcpy(&fLast8BitsZero, &bits, sizeof(fLast8BitsZero)); }"

#pragma link C++ options = version(3) class OldName < int> + ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma link C++ options=version(3) class OldName<int>+;

is more typical white spacing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants