[TPython] Use functions and not macros for reference counting #18377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is recommended by the C Python documentation for runtime dynamic embedding of Python. This prevents linker errors when building TPython against GIL-less Python.
Silencing of warnings is not necessary anymore since the TPython refactoring last year.
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
Test Results 19 files 19 suites 4d 16h 11m 11s ⏱️ For more details on these failures, see this check. Results for commit 98f1101. |
dpiparo
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is recommended by the C Python documentation for runtime dynamic embedding of Python.
This prevents linker errors when building TPython against GIL-less Python.