[tmva][sofie] Remove explicit function definitions that can be implicit #18379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 5d 13h 34m 23s ⏱️ For more details on these failures, see this check. Results for commit cc6f1cc. ♻️ This comment has been updated with latest results. |
guitargeek
changed the title
Follows up on 035cf0c. * Remove IO constructors of classes that don't support IO anyway because there is no `ClassDef` macro call, etc. * Use implicit move constructors and assignments for GNN RModel classes, because all data members can be correctly moved * Delete explicit destructors of helper classes that only reset the unique pointers, which would happen by default anyway * Don't delete copying of RModel and derived classes explicitly. Copying is already implicitly deleted because of the `std::unique_ptr` data members
dpiparo
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on 035cf0c.
Remove IO constructors of classes that don't support IO anyway because there is no
ClassDefmacro call, etc.Use implicit move constructors and assignments for GNN RModel classes, because all data members can be correctly moved
Delete explicit destructors of helper classes that only reset the unique pointers, which would happen by default anyway
Don't delete copying of RModel and derived classes explicitly. Copying is already implicitly deleted because of the
std::unique_ptrdata members