[roottest] use cmake for root/io tests [part5]
#19287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use tail -120 to compare writing and reading of random data Disable correspondent test on Windows where tail is not available
Remove unused TEST defines
Simplify running of macro - remove extra set with loading of compiled macro.
For genreflex invocation use '- o filename.cpp' argument to prevent creation of files in source directory
Pre-compile classes.C macro and load it with ROOTEXE_OPTS to avoid complex testing Split tree cloning and creation on smaller steps and provide individual ref file Make possible to create smaller steps and with proper dependencies
Test Results 20 files 20 suites 3d 8h 47m 41s ⏱️ Results for commit e612f0d. |
pcanal
reviewed
Jul 7, 2025
| if(NOT MSVC OR win_broken_tests) | ||
| ROOTTEST_ADD_TEST(varyingArrayWrite | ||
| MACRO runvaryingArrayWrite.C+ | ||
| OUTCNVCMD tail -120 |
There was a problem hiding this comment.
It appears that the only difference on the log file might file the script name. We might be able to handle this with sed instead of tail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major change is
io/tree.There many tests includes creation and dumping of tree content.
In Makefile it was sequential and dump into single file.
Now creation and reading of each tree run as separated test via
run.CmacroProvide individual ref files for each reading test
Use small cmake function to configure dependency via all these tests
Use fixtures for better dependencies in several other tests