Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF] Fix memory leak in RooAbsData::split #9553

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[RF] Fix memory leak in RooAbsData::split #9553

merged 1 commit into from
Jan 13, 2022

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jan 12, 2022 •
edited
Loading

Fix a memory leak that was introduced in [1], where the owning pointer
returned by RooAbsArg::getObservables was not deleted.

[1] "New RooAbsData::split function for smaller datasets in categories",
commit 5736fd2 in the master branch

@guitargeek
[RF] Fix memory leak in RooAbsData::split
e5d263e 
Fix a memory leak that was introduced in [1], where the owning pointer
returned by `RooAbsArg::getObservables` was not deleted.

[1] "New RooAbsData::split function for smaller datasets in categories",
    commit 5736fd2 in the `master` branch
@guitargeek guitargeek self-assigned this Jan 12, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@guitargeek guitargeek mentioned this pull request Jan 13, 2022
Closed
40 tasks
@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/python3.
Running on macitois19.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@guitargeek guitargeek changed the title [RF] Fix memory leak in RooAbsData::split and code modernization [RF] Fix memory leak in RooAbsData::split Jan 13, 2022
lmoneta
lmoneta approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for the fix!

@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 4 more

@guitargeek guitargeek merged commit abab208 into root-project:master Jan 13, 2022
@guitargeek guitargeek deleted the RooAbsData_leak_1 branch January 13, 2022 10:36
@guitargeek guitargeek mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoneta lmoneta lmoneta approved these changes

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees

@guitargeek guitargeek

Labels
bug in:RooFit/RooStats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guitargeek @phsft-bot @lmoneta