Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v626][RF] Backports of RooFit PRs to v6-26-00-patches: Part 2 #9614

Merged
merged 8 commits into from
Jan 19, 2022
Merged

[v626][RF] Backports of RooFit PRs to v6-26-00-patches: Part 2 #9614

merged 8 commits into from
Jan 19, 2022

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jan 19, 2022 •
edited
Loading

This is a backport of all the RooFit PRs that were merged to master in the last week to v6-26-00-patches (if the right order, to not have the commit history diverge too much).

  1. [RF][PyROOT] New functions for conversion between RooDataHist and NumPy arrays #8784
  2. [RF] Use range-based loops for RooLinkedList #9177
  3. [RF] Make RooProdPdf::_pdfNSetList a std::vector and not RooLinkedList #8595
  4. [RF] factory interface for RooLagrangianMorphFunc #9444

@guitargeek
[RF] New public accessors in RooDataHist for RooDataHist.to_numpy()
6aea9c8
@guitargeek
[RF] Add new RooDataHist.to_numpy() and from_nummpy() for pyROOT
3fc5202 
The interface of these functions was strongly inspired by
`numpy.histogramdd`:

https://numpy.org/doc/stable/reference/generated/numpy.histogramdd.html#numpy.histogramdd

A unit test that makes a closure check by converting a RooDataHist to
numpy and back was also implemented.
@guitargeek
[relnotes] Write about new RooDataHist to NumPy interoperability
85a2d67
@guitargeek
[RF] Explain RooDataHist to NumPy in rf409_NumPyPandasToRooFit
91cf9ca
@guitargeek
[RF] Use range-based loops for RooLinkedList
b5fd993 
This is a followup to commit 2f7936a, using range-based loops or at
least the `begin()` and `end()` member functions for RooLinkedLists
everywhere in RooFit.
@guitargeek
[RF] Make RooProdPdf::_pdfNSetList a std::vector and not RooLinkedList
8a6fd34 
Part of the RooProdPdf modernization with the intention of eventually
deprecating the RooLinkedList.

This change reduces the size of a RooProdPdf from 1600 to 1496 bytes.

A manual schema evolution rule to test the reading of older RooProdPdfs
is implemented in the `LinkDef.h`. The schma evolution is tested by
the stressRooFit tests, which are reading some RooProdPdfs from the
reference files.
@guitargeek guitargeek self-assigned this Jan 19, 2022
@guitargeek guitargeek changed the title [v626][RF] Backports of RooFit PRs to v6-26-00-patches: Part 1 [v626][RF] Backports of RooFit PRs to v6-26-00-patches: Part 2 Jan 19, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@guitargeek guitargeek mentioned this pull request Jan 19, 2022
Closed
40 tasks
@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
See console output.

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-01-19T13:07:41.845Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T13:07:41.845Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T13:13:47.788Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T13:13:47.788Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2022-01-19T13:57:00.705Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T13:57:00.705Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T14:02:43.456Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
  • [2022-01-19T14:02:43.456Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]

@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 4 more

@guitargeek guitargeek merged commit 665db2f into root-project:v6-26-00-patches Jan 19, 2022
@guitargeek guitargeek deleted the v6-26-00-patches_roofit_backports_2 branch January 19, 2022 15:55
@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-01-19T16:58:41.334Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1064 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann Axel-Naumann is a code owner

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@couet couet Awaiting requested review from couet couet is a code owner

@etejedor etejedor Awaiting requested review from etejedor etejedor is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck hageboeck is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner

Assignees

@guitargeek guitargeek

Labels
in:RooFit/RooStats pr:backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guitargeek @phsft-bot @rahulgrit