-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF] Support ShapeSys in JSON tool #9683
Conversation
Can one of the admins verify this patch? |
Tagging @cburgard for review |
Looks good to me. Only one small suggestion: The In addition to that, I'm sure @guitargeek will request you run Thanks a lot for going the extra mile of adding this! |
Done. |
Hi @guitargeek yes please merge the other one first. It should be easy to adapt this one afterwards. |
Ok! The conflicting PR has now been merged. |
Refactor ParamHistFunc treatment to support both MC stat (BB-lite) and user-defined ShapeSys Validated on ATLAS VHbb workspace
It should now be ok, @guitargeek |
@phsft-bot build |
Starting build on |
Build failed on mac1015/python3. Warnings:
|
Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
Build failed on mac11/cxx17. Warnings:
And 1 more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much for implementing this!
The compiler warnings seen in the CI tests will be fixed by #9734.
Build failed on windows10/cxx14. Errors:
|
Refactor ParamHistFunc treatment to support both MC stat (BB-lite)
and user-defined ShapeSys
Validated on ATLAS VHbb workspace