Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v626: Emulated Collection Proxy always need the VectorLooper for the StreamerInfoActions #9764

Merged
merged 1 commit into from
Feb 1, 2022
Merged

v626: Emulated Collection Proxy always need the VectorLooper for the StreamerInfoActions #9764

merged 1 commit into from
Feb 1, 2022

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Jan 31, 2022

This fixes #9136.

Without this commit, SelectLooper would select the 'GenericLooper'
in the case of an emulated proxy for STL collection with (in the
name) a custom allocator. However the GenericLooper only usable
for collection with a compiled collection proxy.

In particular, GenericLooper is calling the 'Next' function which
is not defined for vector ... and emulated collection. Using
it lead to an assert complaining (right fully so) that an
'undefined' function is being called.

@pcanal
Emulated Collection Proxy always need the VectorLooper for the Stream…
9c61d00 
…erInfoActions

This fixes root-project#9136.

Without this commit, SelectLooper would select the 'GenericLooper'
in the case of an emulated proxy for STL collection with (in the
name) a custom allocator.  However the GenericLooper only usable
for collection with a compiled collection proxy.

In particular, GenericLooper is calling the 'Next' function which
is not defined for vector ... and emulated collection.  Using
it lead to an assert complaining (right fully so) that an
'undefined' function is being called.
@pcanal pcanal self-assigned this Jan 31, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal
Copy link
Member Author

pcanal commented Jan 31, 2022

@phsft-bot build just on ROOT-performance-centos8-multicore/default

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal
Copy link
Member Author

pcanal commented Feb 1, 2022

@Axel-Naumann The test failure seems both random and unrelated. Merging.

@pcanal pcanal merged commit bfc85e8 into root-project:v6-26-00-patches Feb 1, 2022
@pcanal pcanal deleted the v626-issue-9136 branch February 1, 2022 01:33
@pcanal pcanal changed the title Emulated Collection Proxy always need the VectorLooper for the StreamerInfoActions v626: Emulated Collection Proxy always need the VectorLooper for the StreamerInfoActions Feb 1, 2022
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T20:36:21.986Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T20:37:30.978Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T21:21:53.225Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T22:04:36.982Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T23:03:32.717Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-02-01T23:07:35.502Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@phsft-bot
Copy link
Collaborator

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2022-02-02T04:20:40.603Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1070 (message):

@pcanal pcanal linked an issue Feb 3, 2022 that may be closed by this pull request
PyROOT in root 6.24 branch hangs while loading CMSSW library #7718
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcanal pcanal

Labels
affects:6.26 in:I/O
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyROOT in root 6.24 branch hangs while loading CMSSW library
2 participants
@pcanal @phsft-bot