Skip to content

[win] Remove compiler flags workarounds #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2022
Merged

[win] Remove compiler flags workarounds #9829

merged 6 commits into from
Mar 12, 2022

Conversation

@bellenot
Copy link
Member

@bellenot bellenot commented Feb 7, 2022

Those workarounds are not needed anymore with the latest VS 2019 and VS 2022

@bellenot
[skip-ci][win] Fix compiler flags workarounds
9d3eb6d 
Those workarounds are not needed anymore with the latest VS 2019 and VS 2022
@bellenot bellenot self-assigned this Feb 7, 2022
@bellenot
Copy link
Member Author

bellenot commented Feb 7, 2022

@phsft-bot build just on windows10/cxx14

@bellenot bellenot changed the title [skip-ci][win] Fix compiler flags workarounds [win] Fix compiler flags workarounds Feb 7, 2022
@bellenot
Copy link
Member Author

bellenot commented Feb 7, 2022

@phsft-bot build just on windows10/cxx14

@phsft-bot
Copy link

phsft-bot commented Feb 7, 2022

Starting build on windows10/cxx14
How to customize builds

@bellenot bellenot requested a review from Axel-Naumann February 7, 2022 16:49
@phsft-bot
Copy link

phsft-bot commented Feb 7, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@bellenot
Fix failing test
914d022 
Fix a test failing due to the removal of compiler flags workarounds
@bellenot bellenot requested a review from eguiraud as a code owner February 8, 2022 07:33
@phsft-bot
Copy link

phsft-bot commented Feb 8, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Feb 8, 2022

Build failed on ROOT-ubuntu2004/soversion.
See console output.

@phsft-bot
Copy link

phsft-bot commented Feb 8, 2022

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

phsft-bot commented Feb 8, 2022

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

phsft-bot commented Feb 8, 2022

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

eguiraud
eguiraud reviewed Feb 8, 2022
View reviewed changes
@bellenot
Revert "Fix failing test"
2a27b91 
This reverts commit 914d022.
@phsft-bot
Copy link

phsft-bot commented Feb 9, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Feb 9, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

phsft-bot commented Mar 3, 2022

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

@bellenot bellenot changed the title [win] Fix compiler flags workarounds [win] Remove compiler flags workarounds Mar 10, 2022
@bellenot bellenot merged commit b92cbb9 into root-project:master Mar 12, 2022
@bellenot bellenot deleted the fix-compiler-flags branch March 12, 2022 11:13
Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this pull request Apr 6, 2022
@bellenot
[win] Remove compiler flags workarounds (root-project#9829)
9dd4d7f 
* [skip-ci][win] Fix compiler flags workarounds

Those workarounds are not needed anymore with the latest VS 2019 and VS 2022

* Fix the correct lines

* Fix failing test

Fix a test failing due to the removal of compiler flags workarounds

* Revert "Fix failing test"

This reverts commit 914d022.

* More compiler flags and increase stack size for a couple of tests

* Code formatting (white space)
enirolf pushed a commit to enirolf/root that referenced this pull request Apr 23, 2025
@bellenot
[win64] Disable failing pythonizations test on Windows 64
491afef 
On Windows 64, after removing the compiler flag workaround (PR root-project#9829), the `pythonizations` test is failing like:
```
1386: -- TEST COMMAND --
1386: cd C:/Users/sftnight/build/release/roottest/python/pythonizations
1386: C:/Python38/python.exe C:/Users/sftnight/git/roottest/python/pythonizations/PyROOT_pythonizationtest.py --fixcling
1386: -- BEGIN TEST OUTPUT --
1386: ============================= test session starts =============================
1386: platform win32 -- Python 3.8.10, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
1386: rootdir: C:\Users\sftnight
1386: collected 7 items
1386:
1386: ..\..\..\..\..\git\roottest\python\pythonizations\PyROOT_pythonizationtest.py . [ 14%]
1386: .....Windows fatal exception: access violation
1386:
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

+1 more reviewer

@eguiraud eguiraud eguiraud left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bellenot bellenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bellenot @phsft-bot @Axel-Naumann @eguiraud