[RF][RelNotes] Mention removal of `const char*` to RooCmdArg conversion #9833

guitargeek · 2022-02-07T22:49:11Z

RooFit got more strict and forbids the implicit construction of
meaningless RooCmdArgs from strings. Our users should be warned about
possible new compiler errors if they make this mistake.

Needs to be backported to the 6.26 branch (CMS already encountered such compiler errors in CMSSW).

This is a followup to #9747.

phsft-bot · 2022-02-07T22:49:17Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-02-07T22:50:14Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-02-07T23:16:16Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_legacy_mlp_mlpHiggs

phsft-bot · 2022-02-07T23:32:48Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-02-07T23:24:36.599Z] C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\include\clang/AST/DeclNodes.inc(490,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Analysis\ThreadSafetyTIL.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Analysis\obj.clangAnalysis.vcxproj]
[2022-02-07T23:24:36.599Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\xmemory(663,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\AST\DeclCXX.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2022-02-07T23:24:36.599Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/ADT/BitVector.h(58,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\AST\CommentLexer.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2022-02-07T23:24:36.600Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/ADT/SmallPtrSet.h(217,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Frontend\InitPreprocessor.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Frontend\obj.clangFrontend.vcxproj]
[2022-02-07T23:24:36.600Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\vector(1489,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\AST\ExprClassification.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\AST\obj.clangAST.vcxproj]
[2022-02-07T23:24:36.600Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/ADT/DenseMap.h(518,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\CodeGen\MachineDominators.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\CodeGen\LLVMCodeGen.vcxproj]
[2022-02-07T23:24:36.987Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3173,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\Edit\Commit.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\Edit\obj.clangEdit.vcxproj]
[2022-02-07T23:24:36.987Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\IPO\BlockExtractor.cpp : fatal error C1001: Internal compiler error. [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\IPO\LLVMipo.vcxproj]
[2022-02-07T23:24:36.987Z] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\memory(3206,66): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\tools\clang\lib\CodeGen\CGOpenCLRuntime.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\tools\clang\lib\CodeGen\obj.clangCodeGen.vcxproj]
[2022-02-07T23:24:36.987Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\include\llvm/ADT/DenseMap.h(109,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm\src\lib\Transforms\Vectorize\VPlanHCFGBuilder.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm\src\lib\Transforms\Vectorize\LLVMVectorize.vcxproj]

And 116 more

phsft-bot · 2022-02-08T00:07:52Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Axel-Naumann · 2022-02-08T11:13:00Z

README/ReleaseNotes/v626/index.md

+### Compile-time protection against creating empty `RooCmdArg`s from strings
+
+The implicit [RooCmdArg](https://root.cern.ch/doc/v626/classRooCmdArg.html) constructor from `const char*` was removed to avoid the accidental construction of meaningless RooCmdArgs that only have a name but no payload.
+This causes new compiler errors in your code if you pass a string instead of a RooCmdArg to various RooFit functions, such as [RooAbsPdf::fitTo()](https://root.cern.ch/doc/v626/classRooAbsPdf.html#a5f79f16f4a26a19c9e66fb5c080f59c5).


Here and everywhere else, please update to use the preferred root.cern:

Suggested change

This causes new compiler errors in your code if you pass a string instead of a RooCmdArg to various RooFit functions, such as [RooAbsPdf::fitTo()](https://root.cern.ch/doc/v626/classRooAbsPdf.html#a5f79f16f4a26a19c9e66fb5c080f59c5).

This causes new compiler errors in your code if you pass a string instead of a RooCmdArg to various RooFit functions, such as [RooAbsPdf::fitTo()](https://root.cern/doc/v626/classRooAbsPdf.html#a5f79f16f4a26a19c9e66fb5c080f59c5).

Axel-Naumann · 2022-02-08T11:16:56Z

README/ReleaseNotes/v626/index.md

+```C++
+pdf.fitTo(*data, "r");
+// Will not compile anymore, as `"r"` is not a recognized command and will be ignored!
+// Instead use: gauss.fitTo(*data, RooFit::Range("r"));


Why gauss instead of pdf?

Axel-Naumann · 2022-02-08T11:18:04Z

README/ReleaseNotes/v626/index.md

+```C++
+pdf.fitTo(*data, "r");
+// Will not compile anymore, as `"r"` is not a recognized command and will be ignored!
+// Instead use: gauss.fitTo(*data, RooFit::Range("r"));


Suggested change

// Instead use: gauss.fitTo(*data, RooFit::Range("r"));

// Instead, to restrict to a range called "r", use:

pdf.fitTo(*data, RooFit::Range("r"));

Axel-Naumann · 2022-02-08T11:19:07Z

README/ReleaseNotes/v626/index.md

+**Example** of an error that is now caught at compile time: confusing the [RooAbsPdf::fitTo()]() function signature with the one of [TH1::Fit()](https://root.cern.ch/doc/v626/classTH1.html#a63eb028df86bc86c8e20c989eb23fb2a) and passing the fit range name as a string literal:
+
+```C++
+pdf.fitTo(*data, "r");


Suggested change

pdf.fitTo(*data, "r");

pdf.fitTo(*data, "r"); // ERROR!

or similar, to make it very visible that is is wrong :-)

lmoneta

LGTM!
Thanks Jonas for the update

RooFit got more strict and forbids the implicit construction of meaningless RooCmdArgs from strings. Our users should be warned about possible new compiler errors if they make this mistake.

phsft-bot · 2022-02-08T13:30:37Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

guitargeek · 2022-02-08T13:31:06Z

Thanks @Axel-Naumann and @lmoneta! I have updated the PR, I'll merge it without tests as it only affects the release notes.

phsft-bot · 2022-02-08T13:35:49Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T13:35:47.410Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T13:37:07Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-02-08T13:37:06.365Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T14:01:23Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T14:01:22.601Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T14:21:51Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T14:21:50.574Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T14:30:29Z

Build failed on mac1015/python3.
Running on macitois19.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T14:30:27.658Z] CMake Error at /Volumes/HDD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T14:37:53Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T14:37:52.626Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-02-08T22:59:22Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-02-08T22:59:21.636Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1073 (message):

phsft-bot · 2022-03-24T15:25:43Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-03-24T15:26:24Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:26:22.669Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:26:30Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:26:29.189Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:26:33Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:26:32.649Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:26:34Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:26:33.155Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:27:28Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:27:27.240Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:28:50Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:28:49.432Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

phsft-bot · 2022-03-24T15:30:36Z

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2022-03-24T15:30:35.048Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1082 (message):

guitargeek added in:RooFit/RooStats affects:6.26 labels Feb 7, 2022

guitargeek added this to the 6.26/00 milestone Feb 7, 2022

guitargeek self-assigned this Feb 7, 2022

guitargeek requested a review from Axel-Naumann as a code owner February 7, 2022 22:49

guitargeek force-pushed the string_to_roocmdarg_1 branch from ca3e1db to cc10163 Compare February 7, 2022 22:50

guitargeek mentioned this pull request Feb 7, 2022

[ROOT6] Fix needed for root master to explicitly pass RooCmdArg cms-sw/cmssw#36903

Merged

Axel-Naumann reviewed Feb 8, 2022

View reviewed changes

lmoneta approved these changes Feb 8, 2022

View reviewed changes

[RF][RelNotes] Mention removal of const char* to RooCmdArg conversion

a578f35

RooFit got more strict and forbids the implicit construction of meaningless RooCmdArgs from strings. Our users should be warned about possible new compiler errors if they make this mistake.

guitargeek force-pushed the string_to_roocmdarg_1 branch from cc10163 to a578f35 Compare February 8, 2022 13:30

guitargeek merged commit e5f7381 into root-project:master Feb 8, 2022

guitargeek deleted the string_to_roocmdarg_1 branch February 8, 2022 13:32

guitargeek mentioned this pull request Feb 8, 2022

[v626][RF][RelNotes] Mention removal of const char* to RooCmdArg conversion #9835

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RF][RelNotes] Mention removal of `const char*` to RooCmdArg conversion #9833

[RF][RelNotes] Mention removal of `const char*` to RooCmdArg conversion #9833

guitargeek commented Feb 7, 2022 •

edited

Loading

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 8, 2022

Axel-Naumann Feb 8, 2022 •

edited

Loading

Axel-Naumann Feb 8, 2022

Axel-Naumann Feb 8, 2022 •

edited

Loading

Axel-Naumann Feb 8, 2022

lmoneta left a comment

phsft-bot commented Feb 8, 2022

guitargeek commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

	This causes new compiler errors in your code if you pass a string instead of a RooCmdArg to various RooFit functions, such as [RooAbsPdf::fitTo()](https://root.cern.ch/doc/v626/classRooAbsPdf.html#a5f79f16f4a26a19c9e66fb5c080f59c5).
	This causes new compiler errors in your code if you pass a string instead of a RooCmdArg to various RooFit functions, such as [RooAbsPdf::fitTo()](https://root.cern/doc/v626/classRooAbsPdf.html#a5f79f16f4a26a19c9e66fb5c080f59c5).

	// Instead use: gauss.fitTo(*data, RooFit::Range("r"));
	// Instead, to restrict to a range called "r", use:
	pdf.fitTo(*data, RooFit::Range("r"));

[RF][RelNotes] Mention removal of const char* to RooCmdArg conversion #9833

[RF][RelNotes] Mention removal of const char* to RooCmdArg conversion #9833

Conversation

guitargeek commented Feb 7, 2022 • edited Loading

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 7, 2022

phsft-bot commented Feb 7, 2022

Failing tests:

phsft-bot commented Feb 7, 2022

Errors:

phsft-bot commented Feb 8, 2022

Failing tests:

Axel-Naumann Feb 8, 2022 • edited Loading

Choose a reason for hiding this comment

Axel-Naumann Feb 8, 2022

Choose a reason for hiding this comment

Axel-Naumann Feb 8, 2022 • edited Loading

Choose a reason for hiding this comment

Axel-Naumann Feb 8, 2022

Choose a reason for hiding this comment

lmoneta left a comment

Choose a reason for hiding this comment

phsft-bot commented Feb 8, 2022

guitargeek commented Feb 8, 2022

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Feb 8, 2022

Errors:

phsft-bot commented Mar 24, 2022

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

phsft-bot commented Mar 24, 2022

Errors:

[RF][RelNotes] Mention removal of `const char*` to RooCmdArg conversion #9833

[RF][RelNotes] Mention removal of `const char*` to RooCmdArg conversion #9833

guitargeek commented Feb 7, 2022 •

edited

Loading

Axel-Naumann Feb 8, 2022 •

edited

Loading

Axel-Naumann Feb 8, 2022 •

edited

Loading