Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic manifest #72

Merged
merged 12 commits into from
Dec 25, 2024
Merged

dynamic manifest #72

merged 12 commits into from
Dec 25, 2024

Conversation

Gyan172004
Copy link
Contributor

@Gyan172004 Gyan172004 commented Dec 19, 2024

Dynamic Manifest Generation for Cross-Browser Support

Fixes #70

Implemented dynamic manifest.json generation to support both Firefox and Chrome browsers individually. This change ensures proper browser-specific configurations are generated during build time.

Key Changes

  • Added manifest generation logic to handle browser-specific requirements

  • -Firefox requires browser_specific_settings and background.scripts

  • Chrome/Edge use background.service_worker

  • Modified watcher.ts to prevent manifest overwriting during file operations

-Changed check workflow

@rootCircle rootCircle self-requested a review December 20, 2024 10:52
package.json Outdated Show resolved Hide resolved
tools/builder.ts Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/bundler.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/watcher.ts Outdated Show resolved Hide resolved
tools/manifest.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
tools/builder.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added documentation Improvements or additions to documentation options-page related to setting/option page config metrics build ci labels Dec 25, 2024
Copy link
Owner

@rootCircle rootCircle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rootCircle rootCircle merged commit 60dc5ac into rootCircle:dev Dec 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build ci config documentation Improvements or additions to documentation metrics options-page related to setting/option page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic manifest.json based on browser type
2 participants