-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic manifest #72
Merged
Merged
dynamic manifest #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootCircle
requested changes
Dec 20, 2024
rootCircle
requested changes
Dec 20, 2024
rootCircle
requested changes
Dec 25, 2024
5 tasks
rootCircle
requested changes
Dec 25, 2024
rootCircle
requested changes
Dec 25, 2024
rootCircle
requested changes
Dec 25, 2024
github-actions
bot
added
documentation
Improvements or additions to documentation
options-page
related to setting/option page
config
metrics
build
ci
labels
Dec 25, 2024
rootCircle
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
ci
config
documentation
Improvements or additions to documentation
metrics
options-page
related to setting/option page
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic Manifest Generation for Cross-Browser Support
Fixes #70
Implemented dynamic manifest.json generation to support both Firefox and Chrome browsers individually. This change ensures proper browser-specific configurations are generated during build time.
Key Changes
Added manifest generation logic to handle browser-specific requirements
-Firefox requires
browser_specific_settings
andbackground.scripts
Chrome/Edge use
background.service_worker
Modified watcher.ts to prevent manifest overwriting during file operations
-Changed check workflow