Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: builtin: UDP reply packet is dropped #86

Closed
AkihiroSuda opened this issue Nov 29, 2019 · 2 comments · Fixed by #87
Closed

port: builtin: UDP reply packet is dropped #86

AkihiroSuda opened this issue Nov 29, 2019 · 2 comments · Fixed by #87
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@AkihiroSuda
Copy link
Member

Terminal 1:

$ rootlesskit --net=slirp4netns --port-driver=builtin -p 0.0.0.0:1234:1234/udp  -- sh -c "nc -u -l -p 1234 < /etc/issue"

Terminal 2:

$ echo foo | nc -u 127.0.0.1 1234

foo is printed on Terminal 1, but /etc/issue is not printed on Terminal 2 when --port-driver is set to builtin.

--port-driver=socat works as expected.

version: e6152ff

containers/podman#4586 (comment)
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 29, 2019 •
edited
Loading

seems we need to port over this: https://github.com/docker/libnetwork/blob/master/cmd/proxy/udp_proxy.go (moby/moby@fac0d87)

@AkihiroSuda AkihiroSuda added the bug Something isn't working label Nov 29, 2019
@AkihiroSuda AkihiroSuda mentioned this issue Nov 29, 2019
Merged
@AkihiroSuda AkihiroSuda added the help wanted Extra attention is needed label Nov 29, 2019
@AkihiroSuda
Copy link
Member Author

Curious, why doesn't VXLAN (Flannel) seem to hit this?

AkihiroSuda added a commit to AkihiroSuda/rootlesskit that referenced this issue Dec 18, 2019
@AkihiroSuda
port/builtin: use libnetwork UDP proxy
b0a0dce 
Fix rootless-containers#86 ("port: builtin: UDP reply packet is dropped")

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this issue Dec 18, 2019
Merged
AkihiroSuda added a commit to AkihiroSuda/docker that referenced this issue Dec 18, 2019
@AkihiroSuda
rootless: fix proxying UDP packets
658723b 
UDP reply packets were not proxied: rootless-containers/rootlesskit#86

The issue was fixed in RootlessKit v0.7.1: rootless-containers/rootlesskit#87

Full changes since v0.7.0: rootless-containers/rootlesskit@v0.7.0...v0.7.1

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this issue Dec 18, 2019
Merged
AkihiroSuda added a commit to AkihiroSuda/docker-library-docker that referenced this issue Dec 18, 2019
@AkihiroSuda
update RootlessKit to v0.7.1
cd00995 
Fix proxying UDP packets (rootless-containers/rootlesskit#86)

Corresponds to moby/moby#40317

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this issue Dec 18, 2019
Merged
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Dec 19, 2019
@AkihiroSuda
rootless: fix proxying UDP packets
e5c333e 
UDP reply packets were not proxied: rootless-containers/rootlesskit#86

The issue was fixed in RootlessKit v0.7.1: rootless-containers/rootlesskit#87

Full changes since v0.7.0: rootless-containers/rootlesskit@v0.7.0...v0.7.1

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Upstream-commit: 658723badd2fe2db6aacfddec17d78df2997a905
Component: engine
AkihiroSuda added a commit to AkihiroSuda/docker that referenced this issue Jan 20, 2020
@AkihiroSuda
rootless: fix proxying UDP packets
325e889 
UDP reply packets were not proxied: rootless-containers/rootlesskit#86

The issue was fixed in RootlessKit v0.7.1: rootless-containers/rootlesskit#87

Full changes since v0.7.0: rootless-containers/rootlesskit@v0.7.0...v0.7.1

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 658723b)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this issue Jan 20, 2020
@AkihiroSuda
rootless: fix proxying UDP packets
934fe59 
UDP reply packets were not proxied: rootless-containers/rootlesskit#86

The issue was fixed in RootlessKit v0.7.1: rootless-containers/rootlesskit#87

Full changes since v0.7.0: rootless-containers/rootlesskit@v0.7.0...v0.7.1

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
(cherry picked from commit 658723badd2fe2db6aacfddec17d78df2997a905)
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Upstream-commit: 325e889ba33d28c34b278d9915a88f6303086dd1
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port/builtin: use libnetwork UDP proxy AkihiroSuda/rootlesskit
1 participant
@AkihiroSuda