Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc-user-nic: support detach-netns #389

Merged
merged 1 commit into from
Aug 8, 2023
Merged

lxc-user-nic: support detach-netns #389

merged 1 commit into from
Aug 8, 2023

Conversation

fahedouch
Copy link
Contributor

fix #380

@fahedouch fahedouch marked this pull request as draft August 7, 2023 19:48
@fahedouch
lxc-user-nic: support detach-netns
d89bf36 
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
@fahedouch fahedouch force-pushed the support-detach-netns-for-lxc-user-nic branch from f9fd3f9 to d89bf36 Compare August 8, 2023 16:55
@fahedouch fahedouch marked this pull request as ready for review August 8, 2023 16:56
@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Aug 8, 2023
AkihiroSuda
AkihiroSuda approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 36622eb into rootless-containers:master Aug 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

lxc-user-nic: support detach-netns
2 participants
@fahedouch @AkihiroSuda