child: reconfigure Pdeathsig (release v0.4.1) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent calls child with Pdeathsig, but it is cleared when newuidmap SUID binary is called rootless-containers#65 (comment) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
changed the title
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
May 15, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) rootless-containers/rootlesskit@e92d5e7...27a0c7a Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/buildkit_poc
that referenced
this pull request
May 15, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
This was referenced May 15, 2019
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 15, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) rootless-containers/rootlesskit@e92d5e7...27a0c7a Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> Upstream-commit: 00c92a671933c0e3f9b67940746d31144902929f Component: engine
kiku-jw
pushed a commit
to kiku-jw/moby
that referenced
this pull request
May 16, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) rootless-containers/rootlesskit@e92d5e7...27a0c7a Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
May 16, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) rootless-containers/rootlesskit@e92d5e7...27a0c7a Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 00c92a6) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 24, 2019
Now the child process is killed when the parent dies (rootless-containers/rootlesskit#66) rootless-containers/rootlesskit@e92d5e7...27a0c7a Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 00c92a671933c0e3f9b67940746d31144902929f) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> Upstream-commit: 8f61032ec4dba329a7206c0d17c184d276db575d Component: engine
virtuald
reviewed
Oct 21, 2020
| // https://github.com/rootless-containers/rootlesskit/issues/65#issuecomment-492343646 | ||
| runtime.LockOSThread() | ||
| err = unix.Prctl(unix.PR_SET_PDEATHSIG, uintptr(unix.SIGKILL), 0, 0, 0) | ||
| runtime.UnlockOSThread() |
There was a problem hiding this comment.
This is incorrect, for PDEATHSIG the parent is the thread, not the process. I'll leave a more detailed comment on the original issue.
There was a problem hiding this comment.
Could you open an issue?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent calls child with Pdeathsig, but it is cleared when newuidmap SUID binary is called
#65 (comment)
Signed-off-by: Akihiro Suda akihiro.suda.cz@hco.ntt.co.jp