Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for broken view autoloading #60

Closed
wants to merge 1 commit into from

Conversation

alwaysblank
Copy link
Member

In previous releases, you could forgo adding a $views prop if your namespacing and class names reflected the structure of your views. It looks (??) like a namespacing change at some point broke this, as I wasn't able to get it to work on a recent project.

This commit fixes the issue, but is likely just a hack; consider this a prompt for a better solution if mine is problematic.

In previous releases, you could forgo adding a `$views` prop if your
namespacing and class names reflected the structure of your views. It
looks (??) like a namespacing change at some point broke this, as I
wasn't able to get it to work on a recent project.

This commit fixes the issue, but is likely just a hack; consider this a
prompt for a better solution if mine is problematic.
@alwaysblank alwaysblank requested a review from QWp6t April 21, 2020 20:28
@QWp6t
Copy link
Member

QWp6t commented Jun 11, 2020

I didn't notice this PR at the time, but I resolved this in daa4fa9

Sorry about that. 😬

@QWp6t QWp6t closed this Jun 11, 2020
@QWp6t QWp6t deleted the fix-auto-view-loading branch June 11, 2020 18:49
@QWp6t QWp6t removed their request for review July 1, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants