Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor/.gitkeep #379

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Remove vendor/.gitkeep #379

merged 1 commit into from
Aug 4, 2018

Conversation

austinpray
Copy link
Contributor

Vendor is a generated directory, there is no reason to have a .gitkeep
that immediately gets blown away on the first composer install

This only serves to mess with tools that try to intelligently determine whether
composer needs to be run for the first time

vendor is a generated directory, there is no reason to have a .gitkeep
that immediately gets blown away on the first composer install
Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has come up once or twice before. I remember having some really minor reasons to keep it but can't recall them. If this eliminates any problems then it's an improvement 👍

@austinpray austinpray merged commit 3d7d6a8 into master Aug 4, 2018
@QWp6t QWp6t deleted the del-vendor-keep branch August 4, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants