Detect HTTPS if wordpress is behind a reverse proxy #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, It'd be great if HTTPS would be working behind a reverse proxy, which is very common when using a PaaS or a WAF, or any decent cloud providers. https://codex.wordpress.org/Function_Reference/is_ssl#Notes Since it's a condition, it does not harm existing wordpress installations.
|
Seems like a good thing to support by default 👍 Maybe this should go above loading the env specific config? It would allow them have logic based on this. |
swalkinshaw
reviewed
Jan 31, 2019
|
@swalkinshaw done. |
austinpray
reviewed
Feb 1, 2019
Co-Authored-By: tristanbes <tristan@yproximite.com>
|
Thank you! |
gabrielwolf
added a commit
to gabrielwolf/bedrock-grunt-wordpress-deploy
that referenced
this pull request
Apr 23, 2019
* commit '4e86bdd45ad328d5077d5956d93ca6ff3207451a': (46 commits) Configure wp-cli so that `wp server` uses correct webroot Update CHANGELOG [ci skip] Update roots/wordpress from 5.1 to 5.1.1 Remove community health files so that defaults from roots/.github are used swap usable of php7 only null coalesce Update CHANGELOG [ci skip] Update roots/wordpress from 5.0.3 to 5.1 CHANGELOG for 1.12.1 [ci skip] Update composer.lock DSN tweaks 1.12.0 change variable to snake case WP_HOME and WP_SITEURL required once Improve required env Detect HTTPS if wordpress is behind a reverse proxy (roots#413) CR allow to not define port in the DSN support passwordless database Update documentation Put an example in the .env.example ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It'd be great if HTTPS would be working behind a reverse proxy, which is very common when using a PaaS or a WAF, or any decent cloud providers.
https://codex.wordpress.org/Function_Reference/is_ssl#Notes
Since it's a condition, it does not harm existing wordpress installations.