Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move disallow indexing mu-plugin to package #521

Merged
merged 2 commits into from
May 29, 2021

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented May 20, 2020

@retlehs retlehs force-pushed the 59-move-disallow-indexing-mu-plugin-to-package branch 3 times, most recently from 26cb26a to be17d25 Compare May 20, 2020 01:44
@@ -95,6 +95,7 @@
/**
* Custom Settings
*/
Config::define('DISALLOW_INDEXING', WP_ENV !== 'production');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Config::define('DISALLOW_INDEXING', WP_ENV !== 'production');
Config::define('DISALLOW_INDEXING', true);

Then add Config::define('DISALLOW_INDEXING', false); to config/environments/staging.php and config/environments/development.php


Alternatively:

Suggested change
Config::define('DISALLOW_INDEXING', WP_ENV !== 'production');
Config::define('DISALLOW_INDEXING', env('DISALLOW_INDEXING') ?? WP_ENV !== 'production');

@swalkinshaw swalkinshaw force-pushed the 59-move-disallow-indexing-mu-plugin-to-package branch from be17d25 to b43d972 Compare May 28, 2021 04:58
@swalkinshaw swalkinshaw requested a review from tangrufus May 28, 2021 04:59
@swalkinshaw
Copy link
Member

Updated this

@swalkinshaw swalkinshaw merged commit 28374de into master May 29, 2021
@swalkinshaw swalkinshaw deleted the 59-move-disallow-indexing-mu-plugin-to-package branch May 29, 2021 02:20
g000m added a commit to g000m/bedrock that referenced this pull request Jul 1, 2021
* Switch to GitHub actions (roots#597)

* Update build status badge

* Move disallow indexing mu-plugin to package (roots#521)

Co-authored-by: QWp6t <hi@qwp6t.me>
Co-authored-by: Scott Walkinshaw <scott.walkinshaw@gmail.com>

* Support .env.local config override (roots#594)

If `.env.local` exists, any values will override and take precedence
over those in `.env`.

This is meant for local development only.

* Default to `WP_DEBUG_LOG=true` in development (roots#505)

Setting WP_DEBUG_LOG to `true` will cause WP to automatically log debug
output to <WP_CONTENT>/debug.log (so app/debug.log) which is a sensible default.

This also comments out the old placeholder value in `.env.example` since
`true` is a better default.

Co-authored-by: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Co-authored-by: Ben Word <ben@benword.com>
Co-authored-by: QWp6t <hi@qwp6t.me>
Co-authored-by: QWp6t <QWp6t@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants