💥 use Dotenv::createImmutable()
#714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QWp6t
force-pushed
the
thread-safe-dotenv
branch
from
ee8c7f3
to
b7af241
Compare
swalkinshaw
approved these changes
Apr 7, 2024
jazzsequence
added a commit
to pantheon-systems/wordpress-composer-managed
that referenced
this pull request
Jun 27, 2024
jazzsequence
added a commit
to pantheon-systems/wordpress-composer-managed
that referenced
this pull request
Jun 27, 2024
* use `Dotenv::createImmutable()` see roots/bedrock#714 * Remove post install .env copy see roots/bedrock#595 * inline comments end in full stops
jazzsequence
added a commit
to pantheon-systems/wordpress-composer-managed
that referenced
this pull request
Jul 31, 2024
* use `Dotenv::createImmutable()` see roots/bedrock#714 * Remove post install .env copy see roots/bedrock#595 * inline comments end in full stops
jazzsequence
added a commit
to pantheon-systems/wordpress-composer-managed
that referenced
this pull request
Aug 1, 2024
* use `Dotenv::createImmutable()` see roots/bedrock#714 * Remove post install .env copy see roots/bedrock#595 * inline comments end in full stops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been brought up a few times internally and in the comments in this repo.
Here's an example scenario in a multithreaded environment:
h/t vlucas/phpdotenv#248 (comment)
The rest of the PHP community has largely moved away from
putenv()andgetenv()due to this limitation, and it's the reason why vlucas/phpdotenv moved away from it as a default and advises against it in their readme.