Display correct bedrock-autoloader version #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrillep
changed the title
|
Or, we can just remove the |
i just happend to stumble upon this when i was looking for something else. :) |
|
Good idea @tangrufus 👍 @chrillep Are you not open to iterating on this PR after receiving feedback? If so, just close it. |
remove version header.
sorry went on vacation. I removed the Version line from plugin header. |
swalkinshaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bedrock/composer.lock
Lines 342 to 343 in 8df74d1
Maybe there is a better way of fetching version from lockfile or adding it to roots/bedrock-autoloader per default. But until then...