Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ improve(minor): no split chunks (@roots/sage) #2399

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

kellymears
Copy link
Contributor

@kellymears kellymears commented Aug 7, 2023

  • don't create vendor chunk by default
  • users can create a vendor chunk using bud.bundle or async imports
  • prevents @wordpress/* dependencies from being enqueued by Acorn for multiple entrypoints when they are only utilized in one

References

Type of change

MINOR: feature

@@ -47,7 +47,7 @@ class Sage extends Extension {
})
.when(
bud.isProduction,
() => bud.minimize().hash().splitChunks(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bud.js minimizes code in production by default so the bud.minimize call can go too.

@github-actions github-actions bot added the test label Aug 7, 2023
@kellymears kellymears added the 🚀! automerge label Aug 7, 2023
@kodiakhq kodiakhq bot merged commit 5c3f02f into main Aug 7, 2023
@kodiakhq kodiakhq bot deleted the improve-sage-no-split-chunks branch August 7, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant