Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Google Analytics from the config #1384

Merged
merged 1 commit into from
Apr 2, 2015
Merged

Conversation

QWp6t
Copy link
Member

@QWp6t QWp6t commented Mar 15, 2015

Implements roots/soil#58

this PR has been updated to remove the mention of GA from lib/config.php

@retlehs
Copy link
Member

retlehs commented Apr 2, 2015

since this will automatically output GA code (with UA-XXXXXX as the ID) if you update to the latest soil (after roots/soil#58 is merged)...

i think we could go ahead and just remove add_theme_support('soil-google-analytics'); from lib/config.php, essentially removing any mention of GA from the theme

@QWp6t
Copy link
Member Author

QWp6t commented Apr 2, 2015

Soil won't output anything related to GA unless add_theme_support('soil-google-analytics', 'UA-XXXX-Y') is added to the theme.

If $gaID is falsey, Soil won't output anything.

Default $gaID is an empty string, which is falsey.

@QWp6t QWp6t force-pushed the QWp6t-optionsGA branch from 54aee62 to 1be28df Compare April 2, 2015 00:47
@retlehs retlehs changed the title Pass ID to Soil GA module Remove mention of Google Analytics from the config Apr 2, 2015
retlehs added a commit that referenced this pull request Apr 2, 2015
Remove mention of Google Analytics from the config
@retlehs retlehs merged commit 82215b3 into master Apr 2, 2015
@retlehs retlehs deleted the QWp6t-optionsGA branch April 2, 2015 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants