This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Add options for Google Analytics #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| add_filter('soil/dummyGA', '__return_false'); // Appends H5BP's GA snippet | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
👮 remove one of these lines
There was a problem hiding this comment.
It's basically the same as what's already in the README for that part:
https://github.com/roots/soil#google-analytics
Note that I have the filter there twice as well with the comments on the right.
I don't mind removing one, but I left it there so that it would clarify exactly what true and false mean in the filter.
| */ | ||
| function google_analytics() { | ||
| if (!defined('GOOGLE_ANALYTICS_ID') || !GOOGLE_ANALYTICS_ID) { | ||
| list($ga_id, $hook) = $options + ['','wp_footer']; |
|
My feedback for some readability tweaks: https://gist.github.com/swalkinshaw/ff3b45c4bf164a3d4573 |
|
👍 |
| if (isset(self::$modules[$module])) { | ||
| return self::$modules[$module]->options; | ||
| } | ||
| if (substr($module, 0, 5)!=='soil-') { |
There was a problem hiding this comment.
this should have triggered a fail on phpcs :(
|
will merge after it passes after the latest phpcs change (#60) |
retlehs
added a commit
that referenced
this pull request
Apr 2, 2015
Add options for Google Analytics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the script will be loaded from the
wp_footerhook, but you can specify any other action hook as the third parameter.I also changed the way the filter works. Instead of the filter being
soil/displayGA, it's nowsoil/dummyGAand returningtruewill use the dummyga()function whilefalsewill load H5BP's snippet.