Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 alpha #1531

Closed
wants to merge 4 commits into from
Closed

Bootstrap 4 alpha #1531

wants to merge 4 commits into from

Conversation

retlehs
Copy link
Sponsor Member

@retlehs retlehs commented Aug 19, 2015

bootstrap released bs4 alpha today, and now you can test it with wordpress & sage by using this branch! here's some more info:

if you take a look at the files changed on this PR, you can see that there's really not any big changes

@kilinkis
Copy link

thanks! how do we download this?

@retlehs
Copy link
Sponsor Member Author

retlehs commented Aug 20, 2015

@kilinkis there's a few different ways:

@kilinkis
Copy link

@retlehs thanks! I was about to clone it cuz I couldn't find the zip button. Anyway, thanks man! I love this project :)

@fgilio
Copy link

fgilio commented Aug 20, 2015

Good news! Thanks for the heads up

@retlehs
Copy link
Sponsor Member Author

retlehs commented Nov 4, 2015

there's new issues that have popped up because of this: twbs/bootstrap#17494

bootstrap 4 now requires jquery 2.x.x in order for the JS to work

@aaemnnosttv
Copy link
Contributor

@austinpray Is it possible to use both versions of jQuery using Webpack? Ie: Bundling the twbs js separately with jQuery 2.x?

@retlehs
Copy link
Sponsor Member Author

retlehs commented Dec 8, 2015

jquery 2 issue has been resolved upstream! alpha 2 is out, i'll rebase this branch with master this week

http://blog.getbootstrap.com/2015/12/08/bootstrap-4-alpha-2/

@retlehs
Copy link
Sponsor Member Author

retlehs commented Dec 9, 2015

this branch is now up to date with sage 8.4.0

@erikbelusic
Copy link

i just came across a new issue where i get the following in the console - Uncaught Error: Bootstrap tooltips require Tether (http://github.hubspot.com/tether/) but never got it before. i assume this is new in alpha 2? because we concatenate all js into main.js the error is blocking my js from running. i know i can include the tether library before, but if not using the parts of bootstrap that require it, its extra overhead

@retlehs
Copy link
Sponsor Member Author

retlehs commented Dec 10, 2015

ugh. they should be adding it as a bower dep...

twbs/bootstrap#17273 (comment)

@retlehs
Copy link
Sponsor Member Author

retlehs commented Dec 10, 2015

twbs/bootstrap#17325

@retlehs
Copy link
Sponsor Member Author

retlehs commented Jan 1, 2016

twbs/bootstrap#18575

@retlehs
Copy link
Sponsor Member Author

retlehs commented Feb 19, 2016

closing this PR as we're not going to keep up with bs4 on sage 8. see sage 9 / #1590

@retlehs retlehs closed this Feb 19, 2016
@retlehs retlehs deleted the bootstrap-4 branch April 3, 2016 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants