-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix injection issues #1862
Fix injection issues #1862
Conversation
Tested this this morning, all seems to be working fine on my end as far as I can tell! |
4d235d9
to
323aee3
Compare
I confirm this is working after the latest commit 419863e |
Hi Guys, I still have the same issue on a fresh install of sage 9 beta 3. Does anyone still have the same issue ? |
This commit solved the issue on my previous project, however a fresh install I still have the same issue. |
What version of node are you using? |
Thanks for the reply: v7.8.0 |
I think they removed or renamed the environment variable for 7.x, but I haven't had a chance to look up how it should be done now. The last I had read about it was in this discussion: nodejs/node#5258 |
Hello Guys,
|
@TrayWeb not working for me :( |
Can you please send your config.json file and also the structure of your files ? |
@TrayWeb it's a clean sage install using the latest commits from the repository. Anyway, here's my config.json
I've also tried with your code, no change. |
Funny enough I have another project, also with sage (beta-3 here), that has EXACTLY the same webpack files and configuration, it's using the same Trellis vagrant box and it works... (this is not a clean sage project, it's an already fully developed site) |
@TrayWeb Thanks! Worked for me! This is what I used:
|
Thanks, @TrayWeb Changing from:
too:
Any chance a fix for this will be commited to master any time soon? |
was this ever fixed? Started a new project and still not watching blade files. |
This should hopefully fix issues with browser-sync not refreshing or injecting when changes are made to template files.
Note that we are no longer passing the copy glob to browser-sync. We are only passing php files to it. Webpack handles everything else.
Still a couple of issues to address: