-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize CSS Assets safe = true #1901
Conversation
I was running into some issues on production builds with z-indexes as well as a few more advanced background gradients, etc. [This issue](vuejs-templates/webpack#614) linked to a solution I thought I should try which fixed it right away. By default I think this should be included in all builds.
Would be nice to see an example and the size difference. |
I've had the issue with Foundation back in Sage 8 as well. Same fix. |
So I have 2 css files in my build,
And before:
This is a production project with 99% of the code written. Not much of a difference iirc 😉 |
Oops, sorry you also said an example. On this one project in |
Related #1610 (comment) |
@oxyc oh word! looks like this just didn't get ported over in the new Sage. |
* upstream/master: Controller examples Change syntax of template call to match other files in views/ Remove test output. Don't remove comments when clearing files. Use latest Controller (soberwp/controller#26) assets -> resources/assets Update operator for template call Remove post format reference in template call Update comments, add some more Add soberwp/controller Optimize CSS Assets safe = true (roots#1901) update inline documentation to reflect correct theme file locations Fix stylelint errors. Add Stylelint linting for scss files. Use official SASS transpiled partials instead Add Tachyons PR link Update CHANGELOG.md Add Tachyons as CSS framework option Add Tachyons as a CSS framework option # Conflicts: # resources/assets/styles/common/_global.scss # resources/assets/styles/common/_variables.scss # resources/assets/styles/components/_comments.scss # resources/assets/styles/components/_forms.scss # resources/assets/styles/components/_wp-classes.scss # resources/assets/styles/layouts/_header.scss # resources/assets/styles/main.scss # yarn.lock
I was running into some issues on production builds with z-indexes as well as a few more advanced background gradients, etc. This issue linked to a solution I thought I should try which fixed it right away. By default I think this should be included in all builds.