Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sage 10 to Laravel Mix #2172

Merged
merged 5 commits into from
May 1, 2019
Merged

Move Sage 10 to Laravel Mix #2172

merged 5 commits into from
May 1, 2019

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented May 1, 2019

Changelog

Enhancements

  • Change to Laravel Mix.
  • Clean up and refactor starter styles.
  • Bump Bootstrap and related dependencies (Popper.js).
  • Add missing trailing space to ! in the body_class filter.
  • Use asset()->uri() where applicable for sanity purposes (despite asset() defaulting to ->uri()).
  • Add sanity linebreak to the li in comments.blade.php.
  • Rename main.css and main.js to app.css and app.js.
  • Make app.js comments uniform.
  • Add missing finalize() to about.js.
  • Change add_editor_style() to app.css as admin.css does not exist.
  • Remove autoload from styles/scripts.
  • Remove $ import on customizer.js as Mix autoload will handle that.
  • Remove sage-installer (will be replaced at a later date).
  • Remove unnecessary fields in package.json as it will never be published.
  • Bump Node.js version in README.
  • Bump dependencies.
  • Automatically remove Blade cache when theme is activated, changed, or removed.

Bugfixes

  • Fix conditional on comments.blade.php.

Notes

  • Sage will no longer lint on build by default. Documentation will be provided to add this yourself. yarn run lint is still available as well as default rules for editor plugins.
  • Sage will no longer optimize images on build by default. Documentation will be provided to add this yourself.

Todo

  • Change Acorn's manifest/asset class to handle leading slashes. Perhaps Str::start($path, '/')?
  • Update documentation for Sage 10.
  • Bump Add wp_body_open hook (WP 5.2+) #2167 for when 5.2 releases.
  • Sage CLI.

Clean up and refactor starter styles
Remove autoload from styles/scripts
Remove $ import on customizer.js as Mix autoload will handle that
Fix conditional on comments.blade.php
Bump PHP version to 7.1.3 on Travis
Remove unnecessary fields in package.json as it will never be published
Rename main.css/main.js to app.css/app.js
Automatically remove Blade cache when theme is activated, changed, or removed
@Log1x Log1x changed the title Change to Laravel Mix Move Sage 10 to Laravel Mix May 1, 2019
@Log1x
Copy link
Member Author

Log1x commented May 1, 2019

Have to go out for a few, will fix conflicts when I return. (Sorry)

package.json Outdated Show resolved Hide resolved
Log1x added 4 commits May 1, 2019 17:00
Fix typo in lint:scripts
Restore double quotes in list:styles
Add missing space after ! in body_class filter
Change add_editor_style() back to app.css for now
Add missing finalize() to about.js
Uncomment Bootstrap Navbar Fix (although I do not know if its still needed)
Add linebreak to li in comments.blade.php
Bump Node.js version in README
Restore my initial .editorconfig change
Make app.js comments uniform
Remove sage-installer (will be replaced)
Bump dependencies for good measure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants