Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken source maps and remove unnecessary conditionals #2268

Merged
merged 1 commit into from
Jul 16, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix broken source maps and remove conditionals
Resolves #2266

Laravel Mix has a bug where source maps are not generated if you do not
specify the source map type (the second argument). This corrects that.

Co-authored-by: Matt Mirus <matt@mattmirus.com>
knowler and mmirus committed Jul 16, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit f72c1e6c9df9af95967655dbca1eef88d263b7ed
8 changes: 2 additions & 6 deletions webpack.mix.js
Original file line number Diff line number Diff line change
@@ -51,11 +51,7 @@ mix.options({
});

// Source maps when not in production.
if (!mix.inProduction()) {
mix.sourceMaps();
}
mix.sourceMaps(false, 'source-map');

// Hash and version files in production.
if (mix.inProduction()) {
mix.version();
}
mix.version();