Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix the comment list output #3184

Merged
merged 1 commit into from
Feb 2, 2024
Merged

🩹 Fix the comment list output #3184

merged 1 commit into from
Feb 2, 2024

Conversation

Log1x
Copy link
Sponsor Member

@Log1x Log1x commented Feb 2, 2024

This was annoying.

Apparently $comments gets forcefully overridden when inside of the WordPress comments template. Not something I had thought about in a long time and it left me insanely confused on why I kept getting an array of comments instead of the HTML markup when setting 'echo' => false.

@github-actions github-actions bot added views php Pull requests that update PHP code labels Feb 2, 2024
@retlehs retlehs merged commit 308cc20 into main Feb 2, 2024
4 checks passed
@retlehs retlehs deleted the fix/comment-list-output branch February 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update PHP code views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants